Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($http): add check for functions in params #16132

Closed
wants to merge 4 commits into from
Closed

fix($http): add check for functions in params #16132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5060234
Update http.js
carlfranz Jul 27, 2017
cbfafad
fix($http): add check for functions in params
carlfranz Jul 27, 2017
7ee320a
test($http): serialize functions
carlfranz Jul 27, 2017
a787ece
test($http): default serializer
carlfranz Jul 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function $HttpParamSerializerProvider() {
if (!params) return '';
var parts = [];
forEachSorted(params, function(value, key) {
if (value === null || isUndefined(value)) return;
if (value === null || isUndefined(value) || isFunction(value)) return;
if (isArray(value)) {
forEach(value, function(v) {
parts.push(encodeUriQuery(key) + '=' + encodeUriQuery(serializeValue(v)));
Expand Down
4 changes: 4 additions & 0 deletions test/ng/httpSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2345,6 +2345,10 @@ describe('$http param serializers', function() {
expect(jqrSer({someDate: new Date('2014-07-15T17:30:00.000Z')})).toEqual('someDate=2014-07-15T17:30:00.000Z');
});

it('should NOT serialize functions', function() {
expect(defSer({foo: 'foov', bar: function() {}})).toEqual('bar=barv');
});

});

describe('default array serialization', function() {
Expand Down