Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: Clarify documentation of input[week] #16103

Closed
wants to merge 1 commit into from
Closed

docs: Clarify documentation of input[week] #16103

wants to merge 1 commit into from

Conversation

SteveAndrewArcher
Copy link
Contributor

Add a note to the documentation of input[week] to explicitly state that
the resulting date object's value is set to Thursday at midnight of the
specified week

Resolves #15883

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

docs update

What is the current behavior? (You can also link to an open issue here)

#15883
The docs do not specify the day and time of a Date created by input[week]

What is the new behavior (if this is a feature change)?

The docs indicate that a Date created by input[week] will have a value of 00:00:00 on Thursday of the specified week

Does this PR introduce a breaking change?

No

Please check if the PR fulfills these requirements

Other information:
Thought this looked like a nice opportunity for baby's first pull request! Hope I did everything right...

Add a note to the documentation of input[week] to explicitly state that
the resulting date object's value is set to Thursday at midnight of the
specified week

Resolves #15883
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for input[week] doesn't mention what will be the underlying Date object
2 participants