This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(doc-gen): insert current tagged version if missing from list of… #16099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all versions In commit ce49edc, we switched to npm info (now yarn info) instead of the local git repository information to get the list of currently available versions for the docs app. This means that during a release the version that is currently tagged is not yet available on npm, and therefore our list of available versions is incomplete. We now simply add the current build version (read from build/version.json) to the list of all versions if it fulfills the following conditions: - it is not a snapshot build - it is not already part of the list of all versions (i.e. if you are building locally) Closes angular#15741
petebacondarwin
approved these changes
Jul 12, 2017
Narretz
added a commit
that referenced
this pull request
Jul 12, 2017
… all versions In commit ce49edc, we switched to npm info (now yarn info) instead of the local git repository information to get the list of currently available versions for the docs app. This means that during a release the version that is currently tagged is not yet available on npm, and therefore our list of available versions is incomplete. We now simply add the current build version (read from build/version.json) to the list of all versions if it fulfills the following conditions: - it is not a snapshot build - it is not already part of the list of all versions (i.e. if you are building locally on a tagged commit) Closes #15741 Closes #16099
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… all versions
In commit ce49edc, we switched to npm info (now yarn info)
instead of the local git repository information to get the list of currently available versions for
the docs app. This means that during a release the version that is currently tagged is not yet
available on npm, and therefore our list of available versions is incomplete.
We now simply add the current build version (read from build/version.json) to the list of all
versions if it fulfills the following conditions:
Closes #15741
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore
What is the current behavior? (You can also link to an open issue here)
see above
Please check if the PR fulfills these requirements
Other information: