-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Overload "component" method to accept object map of components #16062
Conversation
I am not a big fan of this "feature" in other APIs ( It's 👎 from me. |
In my defense, it was requested in #14579 which has "pr's plz" label 😊 |
Imho it should be atleast the same for both components and directives. I find it confusing that a directive offers this way to register but a component does not. |
I suggested that we would merge if a PR was provided, simply because it makes the API consistent with that of directive() |
Just to be clear, I don't feel strongly about this. I just don't like it (which is my personal preference), but if others think it's fine I won't stand in your way 😁 |
Ok. @ksvitkovsky once you provide the tests we can move this forward. |
@Narretz I added the tests in the first commit, should I add more cases? |
@ksvitkovsky Oh, someone tagged this as "needs test". Sorry. I will review and get back if anything else is needed. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
um, I'm okay if that does matter 😄 |
@ksvitkovsky No worries, this message is only for maintainers - it happens when the commits in the PR are by more than 1 author. Since it's only you (who has signed the CLA) and me, we're good. ;) |
@Narretz cool, thanks 😊 |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
"component" method does not allow multiple components registration
What is the new behavior (if this is a feature change)?
"component" method accepts object as a parameter where the keys are component names and the values are the component definition objects
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements