test(e2e): replace browser.getLocationAbsUrl() deprecated function with browser.getCurrentUrl() #16053
Conversation
…th browser.getCurrentUrl() According to angular/protractor#3969, browser.getLocationAbsUrl() is now deprecated and it recommends using browser.getCurrentUrl instead
…urrentUrl() According to angular/protractor#3969, browser.getLocationAbsUrl() is now deprecated and it recommends using browser.getCurrentUrl instead
|
Hello! Can anyone tell me why the CI build failed? Thanks. |
|
Did you take a look at the logs on Travis? Usually they have some info. It's also possible that this is a flake. |
|
@Narretz Yes I did. There is a connection refused:
Can you rebuild it? Thanks! |
|
Restarted. Note that this must be changed in https://github.com/angular/angular-phonecat, too. For that we also need to check we are using an up to date Protractor version. |
|
Hello @Narretz. I can do it. Is there a problem updating Protractor version? |
|
I don't think so. It was just a note. Merging into the tutorial repo is a
different thing, but you don't to do that
Alejandro López <[email protected]> schrieb am Do., 15. Juni 2017
19:53:
… Hello @Narretz <https://github.com/narretz>. I can do it. Is there a
problem updating Protractor version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16053 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGYSc2TFk0ECy-Z1kyyhL0TTYk6HLDrks5sEW98gaJpZM4N6kV4>
.
|
|
The tutorial changes (which are invalid as they are in this PR) are being taken care of in #16753 and angular/angular-phonecat#430. |
…`browser.getCurrentUrl()` According to angular/protractor#3969, `browser.getLocationAbsUrl()` is now deprecated and `browser.getCurrentUrl()` should be used instead. Closes #16053
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test
What is the current behavior? (You can also link to an open issue here)
There are many references to
browser.getLocationAbsUrl()deprecated function (Protractor).A warning appears when e2e tests are running, it recommend using
browser.getCurrentUrl()instead.What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
Tutorial documentation references also updated.