-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs($rootScope.Scope): fixed typo on $watch docs #16050
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Thanks for the PR!
This still sounds correct to me (maybe a comma or two could be added), whereas:
does not. It's ment to say that you should not use it on both
Which does need: Maybe rephrasing could be a possibility if there's some confusion, but certainly not a typo regarding |
Thanks, now it's clear to me. Yeah, the best solution here is rephrasing, may be with "or contain" in brackets. |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
SGTM 👍 |
@witcold Do you still want to update this PR? |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: