Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($rootScope.Scope): fixed typo on $watch docs #16050

Closed
wants to merge 1 commit into from
Closed

docs($rootScope.Scope): fixed typo on $watch docs #16050

wants to merge 1 commit into from

Conversation

witcold
Copy link

@witcold witcold commented Jun 13, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@frederikprijck
Copy link
Contributor

frederikprijck commented Jun 13, 2017

Thanks for the PR!
However, I don't think that was a typo.

This should not be used to watch for changes in objects that are or contain File objects due to limitations with angular.copy.

This still sounds correct to me (maybe a comma or two could be added), whereas:

This should not be used to watch for changes in objects that are contain File objects due to limitations with angular.copy.

does not.

It's ment to say that you should not use it on both

  • File Objects
  • Objects that contain File objects (but are not File objevts themselves)

Which does need: objects that are or contain File objects.

Maybe rephrasing could be a possibility if there's some confusion, but certainly not a typo regarding or if you ask me.

@witcold
Copy link
Author

witcold commented Jun 13, 2017

Thanks, now it's clear to me. Yeah, the best solution here is rephrasing, may be with "or contain" in brackets.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Jun 14, 2017

rephrasing, may be with "or contain" in brackets.

SGTM 👍

@Narretz
Copy link
Contributor

Narretz commented Jun 29, 2017

@witcold Do you still want to update this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants