Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix broken link - point to list of Pluralsight courses on AngularJS #16042

Closed

Conversation

sauravbhattacharya001
Copy link
Contributor

AngularJS docs update: Currently, the link to Pluralsight at the bottom of the page https://docs.angularjs.org/guide/external-resources is broken. This will edit the link to a generic list of all AngularJs course on Pluralsight. This is an isolated UI change to a public facing document, therefore there are no breaking changes anticipated.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@sauravbhattacharya001
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 8, 2017
@sauravbhattacharya001 sauravbhattacharya001 changed the title Fix broken link - point to a generic list of Pluralsight courses on A… Fix broken link - point to list of Pluralsight courses on AngularJS Jun 8, 2017
@sauravbhattacharya001
Copy link
Contributor Author

From the log, there were 2 types of errors:

launcher.sauce - Heartbeat to firefox 47 failed

and

PROXY 127.0.0.1:51852 failed to send half-close

Can someone look into why this might be happening? Also, is it worth considering running doc builds separately?

@@ -139,7 +139,7 @@ You can find a larger list of AngularJS external libraries at [ngmodules.org](ht
[CodeAcademy](http://www.codecademy.com/courses/javascript-advanced-en-2hJ3J/0/1),
[CodeSchool](https://www.codeschool.com/courses/shaping-up-with-angular-js)
* **Paid online:**
[Pluralsight (3 courses)](http://www.pluralsight.com/training/Courses/Find?highlight=true&searchTerm=angularjs),
[Pluralsight](https://app.pluralsight.com/library/search?q=angularjs),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL requires the user to sign in. I think we should use https://www.pluralsight.com/search?q=angularjs instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have made the change.

@gkalpak gkalpak closed this in 42299e9 Jun 12, 2017
gkalpak pushed a commit that referenced this pull request Jun 12, 2017
@sauravbhattacharya001 sauravbhattacharya001 deleted the patch-1 branch June 12, 2017 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants