Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide): component example update #16003

Closed
wants to merge 1 commit into from
Closed

docs(guide): component example update #16003

wants to merge 1 commit into from

Conversation

sercaneraslan
Copy link
Contributor

There is no need empty function on Components Controller anymore. Components are had a empty Controller by the default.

@sercaneraslan
docs(guide): component example update
c2da3fc 
There is no need empty function on components controller anymore.
Components are had a empty controller by the default.
@gkalpak
Copy link
Member

gkalpak commented May 22, 2017

I think the HeroDetailController is defined as a placeholder, for the logic that is added in the next section. That said, I don't think it is a bad idea to show that the controller property is optional (when there is no logic).

gkalpak pushed a commit that referenced this pull request May 22, 2017
@sercaneraslan @gkalpak
docs(guide/component): remove redundant empty controller from example
91b4eb0 
There is no need for empty controller functions on components, since this is the
default.

Closes #16003
@gkalpak gkalpak closed this in 63b6d64 May 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sercaneraslan @gkalpak @googlebot