Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

test($log): run all $log tests in IE9 & non-IE9 logging mode #15995

Merged
merged 1 commit into from
May 24, 2017
Merged

test($log): run all $log tests in IE9 & non-IE9 logging mode #15995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
242 changes: 126 additions & 116 deletions test/ng/logSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
describe('$log', function() {
var $window, logger, log, warn, info, error, debug;



beforeEach(module(function($provide) {
$window = {
navigator: {userAgent: window.navigator.userAgent},
Expand Down Expand Up @@ -67,147 +65,159 @@ describe('$log', function() {
}
));

it('should work if $window.navigator not defined', inject(
function() {
delete $window.navigator;
},
function($log) {}
));
runTests({ie9Mode: false});
runTests({ie9Mode: true});

function runTests(options) {
var ie9Mode = options.ie9Mode;

describe('IE logging behavior', function() {
function removeApplyFunctionForIE() {
log.apply = log.call =
function attachMockConsoleTo$window() {
// Support: IE 9 only
// Simulate missing apply on console methods in IE 9.
if (ie9Mode) {
log.apply = log.call =
warn.apply = warn.call =
info.apply = info.call =
error.apply = error.call =
debug.apply = debug.call = null;
}

$window.console = {log: log,
$window.console = {
log: log,
warn: warn,
info: info,
error: error,
debug: debug};
debug: debug
};
}

it('should work in IE where console.error doesn\'t have an apply method', inject(
removeApplyFunctionForIE,
function($log) {
describe(ie9Mode ? 'IE 9 logging behavior' : 'Modern browsers\' logging behavior', function() {
beforeEach(module(attachMockConsoleTo$window));

it('should work if $window.navigator not defined', inject(
function() {
delete $window.navigator;
},
function($log) {}
));

it('should have a working apply method', inject(function($log) {
$log.log.apply($log);
$log.warn.apply($log);
$log.info.apply($log);
$log.error.apply($log);
$log.debug.apply($log);
expect(logger).toEqual('log;warn;info;error;debug;');
})
);

// Support: Safari 9.1 only, iOS 9.3 only
// For some reason Safari thinks there is always 1 parameter passed here.
if (!/\b9\.\d(\.\d+)* safari/i.test(window.navigator.userAgent) &&
!/\biphone os 9_/i.test(window.navigator.userAgent)) {
it('should not attempt to log the second argument in IE if it is not specified', inject(
function() {
log = function(arg1, arg2) { logger += 'log,' + arguments.length + ';'; };
warn = function(arg1, arg2) { logger += 'warn,' + arguments.length + ';'; };
info = function(arg1, arg2) { logger += 'info,' + arguments.length + ';'; };
error = function(arg1, arg2) { logger += 'error,' + arguments.length + ';'; };
debug = function(arg1, arg2) { logger += 'debug,' + arguments.length + ';'; };
},
removeApplyFunctionForIE,
function($log) {
$log.log();
$log.warn();
$log.info();
$log.error();
$log.debug();
expect(logger).toEqual('log,0;warn,0;info,0;error,0;debug,0;');
})
);
}
});

describe('$log.debug', function() {

beforeEach(initService(false));

it('should skip debugging output if disabled', inject(
function() {
$window.console = {log: log,
warn: warn,
info: info,
error: error,
debug: debug};
},
function($log) {
$log.log();
$log.warn();
$log.info();
$log.error();
$log.debug();
expect(logger).toEqual('log;warn;info;error;');
}));

// Support: Safari 9.1 only, iOS 9.3 only
// For some reason Safari thinks there is always 1 parameter passed here.
if (!/\b9\.\d(\.\d+)* safari/i.test(window.navigator.userAgent) &&
!/\biphone os 9_/i.test(window.navigator.userAgent)) {
it('should not attempt to log the second argument in IE if it is not specified', inject(
function() {
log = function(arg1, arg2) { logger += 'log,' + arguments.length + ';'; };
warn = function(arg1, arg2) { logger += 'warn,' + arguments.length + ';'; };
info = function(arg1, arg2) { logger += 'info,' + arguments.length + ';'; };
error = function(arg1, arg2) { logger += 'error,' + arguments.length + ';'; };
debug = function(arg1, arg2) { logger += 'debug,' + arguments.length + ';'; };
},
attachMockConsoleTo$window,
function($log) {
$log.log();
$log.warn();
$log.info();
$log.error();
$log.debug();
expect(logger).toEqual('log,0;warn,0;info,0;error,0;debug,0;');
})
);
}
));

});

describe('$log.error', function() {
var e, $log;

function TestError() {
Error.prototype.constructor.apply(this, arguments);
this.message = undefined;
this.sourceURL = undefined;
this.line = undefined;
this.stack = undefined;
}
TestError.prototype = Object.create(Error.prototype);
TestError.prototype.constructor = TestError;

beforeEach(inject(
function() {
e = new TestError('');
$window.console = {
error: jasmine.createSpy('error')
};
},

function(_$log_) {
$log = _$log_;
}
));

it('should pass error if does not have trace', function() {
$log.error('abc', e);
expect($window.console.error).toHaveBeenCalledWith('abc', e);
});
describe('$log.debug', function() {

beforeEach(initService(false));

it('should skip debugging output if disabled', inject(
function() {
$window.console = {log: log,
warn: warn,
info: info,
error: error,
debug: debug};
},
function($log) {
$log.log();
$log.warn();
$log.info();
$log.error();
$log.debug();
expect(logger).toEqual('log;warn;info;error;');
}
));

if (msie || /\bEdge\//.test(window.navigator.userAgent)) {
it('should print stack', function() {
e.stack = 'stack';
$log.error('abc', e);
expect($window.console.error).toHaveBeenCalledWith('abc', 'stack');
});
} else {
it('should print a raw error', function() {
e.stack = 'stack';
$log.error('abc', e);
expect($window.console.error).toHaveBeenCalledWith('abc', e);
});
}

it('should print line', function() {
e.message = 'message';
e.sourceURL = 'sourceURL';
e.line = '123';
$log.error('abc', e);
expect($window.console.error).toHaveBeenCalledWith('abc', 'message\nsourceURL:123');
describe('$log.error', function() {
var e, $log;

function TestError() {
Error.prototype.constructor.apply(this, arguments);
this.message = undefined;
this.sourceURL = undefined;
this.line = undefined;
this.stack = undefined;
}
TestError.prototype = Object.create(Error.prototype);
TestError.prototype.constructor = TestError;

beforeEach(inject(
function() {
e = new TestError('');
$window.console = {
error: jasmine.createSpy('error')
};
},

function(_$log_) {
$log = _$log_;
}
));

it('should pass error if does not have trace', function() {
$log.error('abc', e);
expect($window.console.error).toHaveBeenCalledWith('abc', e);
});

if (msie || /\bEdge\//.test(window.navigator.userAgent)) {
it('should print stack', function() {
e.stack = 'stack';
$log.error('abc', e);
expect($window.console.error).toHaveBeenCalledWith('abc', 'stack');
});
} else {
it('should print a raw error', function() {
e.stack = 'stack';
$log.error('abc', e);
expect($window.console.error).toHaveBeenCalledWith('abc', e);
});
}

it('should print line', function() {
e.message = 'message';
e.sourceURL = 'sourceURL';
e.line = '123';
$log.error('abc', e);
expect($window.console.error).toHaveBeenCalledWith('abc', 'message\nsourceURL:123');
});
});
});
});
}


function initService(debugEnabled) {
return module(function($logProvider) {
$logProvider.debugEnabled(debugEnabled);
});
}

});