This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($http): correct and clarify default transforms #15906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- baddata error described incorrect http behavior, and workarounds - httpProvider defaults were missing transformResponse / transformRequest - http was not clear about JSON detection strategy Closes angular#15897
gkalpak
reviewed
Apr 11, 2017
src/ng/http.js
Outdated
| * into JSON format. | ||
| * | ||
| * - **`defaults.transformResponse`** - | ||
| * `{Array<function(data, headersGetter, status)>|function((data, headersGetter, status))}` - |
There was a problem hiding this comment.
Why double ((/)) in function((...))?
src/ng/http.js
Outdated
| * An array of functions (or a single function) which are applied to the response data. By default, | ||
| * this is an array which applies one response transformation function that does two things: | ||
| * | ||
| * - If XSRF prefix is detected, strip it |
There was a problem hiding this comment.
I don't think "XSRF prefix" is accurate. The prefix won't prevent an XSRF afaict, it will just prevent a potential XSRF vulnerability to be combined with other vulnerabilities.
EDIT: I see you've copied it from elsewhere. I'm not 100% sure, so I don't feel strongly about it 😁
There was a problem hiding this comment.
I was wondering about this too .. let's keep it for now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15897