test(jQuery): run tests with jQuery 2.1, 2.2 & 3.2 #15843
Conversation
docs/content/tutorial/step_09.ngdoc
Outdated
| "angular-route": "1.5.x", | ||
| "angular": "1.6.x", | ||
| "angular-mocks": "1.6.x", | ||
| "angular-route": "1.6.x", |
There was a problem hiding this comment.
Upgrading the tutorial form 1.5.x to 1.6.x requires more changes. There are probably more, but off the top of my head:
- The code on https://github.com/angular/angular-phonecat needs to be updated to match the changes here.
- Some
hrefs (on some steps) need to take into account the new default hashPrefix (!). - The code that explicitly sets the hash prefix to
!needs to be removed (and maybe some text referring to it).
In any case, I would not make the tutorial changes as part of this PR.
There was a problem hiding this comment.
OK, I'll revert them here.
Do you think I can perhaps leave jQuery 3.1 -> 3.2 update? That shouldn't require any changes in user code.
There was a problem hiding this comment.
In the tutorial, it was 2.2.x --> 3.2.x. Is 1.5.x compatible with jQuery 3.x?
There was a problem hiding this comment.
Yes, AngularJS 1.5 is tested with jQuery 2.1.4, 2.2.4 & 3.1.0.
There was a problem hiding this comment.
But jQuery follows semver since 1.12/2.2 so there are no breaking changes in 3.2.1.
mgol
force-pushed
the
jquery-3.2
branch
3 times, most recently
from
0690d33 to
de69b38
Compare
|
This PR is now blocked on #15851. |
Also, update jQuery 2.2.x mentions in the tutorial to 3.2.x.
|
The PR is now unblocked, PTAL. |
Also, update jQuery 2.2.x mentions in the tutorial to 3.2.x. Closes #15843
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test update.
What is the current behavior? (You can also link to an open issue here)
We test with jQuery 2.1, 2.2 & 3.1.
What is the new behavior (if this is a feature change)?
We test with jQuery 2.1, 2.2 & 3.2.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information:
Also, update AngularJS 1.5 mentions in the docs to 1.6.