docs ($compile): add error documentation for noslot error in $compile #15828
Conversation
there was no error page for the $compile:noslot error this resolves angular#15790
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
It says that I need CLA but I've already filled one out. |
|
I checked and it was because my git signature was for my work email. I've added my work email as an alternate email to my google account, how do I get the CLA bot to rerun the check? Thanks. |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
Is there anything else I need to do/update etc to get this merged? :) |
|
I will review the PR this week |
| // This example will generate a no slot error. | ||
|
|
||
| var componentConfig = { | ||
| template: '<div style="border: 1px solid black;">' + |
There was a problem hiding this comment.
Remove the styles, they are unnecessary
| transclude: { | ||
| // The key value pairs here are considered "slots" that are provided for components to slot into. | ||
| slotProvided: 'slottedComponent', // mandatory transclusion, | ||
| optionalSlot: '?optionalComponent', // optional transclusion |
There was a problem hiding this comment.
Remove the optional transclusion (also from the template), as they are not the focus of the error
| @fullName No matching slot in parent directive | ||
| @description | ||
|
|
||
| This error occurs when declaring a specific slot in a ng-transclude which does not map to the transclude property of the directive. |
There was a problem hiding this comment.
"Which does not map to a specific slot defined in the transclude property of the directive"
| ```js | ||
| // In this example the template has a declared slot missing from the transclude definition. | ||
| // This example will generate a no slot error. | ||
|
|
| } | ||
| }; | ||
|
|
||
| angular |
There was a problem hiding this comment.
Please remove the component registration, it's unnecessary
| This error occurs when declaring a specific slot in a ng-transclude which does not map to the transclude property of the directive. | ||
|
|
||
| ```js | ||
| // In this example the template has a declared slot missing from the transclude definition. |
There was a problem hiding this comment.
Can you please move the introductory description out of the code block and put it before the code block? Also for the working example
| ``` | ||
|
|
||
| ```js | ||
| \\ if we the following change we will no longer get no slot error. |
removed styling moved comments outside of code blocks removed unneeded directive in example
insert missing "make" to fix grammar
"no slot" -> "noslot"
remove second style tag from example
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Thanks @JoshuaJWilborn - for future PRs, additional commits with adjustments don't have to have a "perfect commit message" because we will squash them into one in the end. It's also a good idea to create a new branch for each PR. |
there was no error page for the $compile:noslot error
this resolves #15790
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: