Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($httpBackend): add catch() block to example #15822

Closed
wants to merge 1 commit into from

Conversation

xfg
Copy link
Contributor

@xfg xfg commented Mar 16, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.

What is the current behavior? (You can also link to an open issue here)
MyController example does not pass through the test it should fail authentication

What is the new behavior (if this is a feature change)?
MyController example passes through the test it should fail authentication.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

`MyController` passes through test `it should fail authentication`.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@xfg
Copy link
Contributor Author

xfg commented Mar 16, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak gkalpak closed this in eacf06f Mar 20, 2017
gkalpak pushed a commit that referenced this pull request Mar 20, 2017
Make the `it should fail authentication` test pass.

Closes #15822
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants