Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(faq): document the AngularJS/jqLite deprecation strategy #15819

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 15, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.

What is the current behavior? (You can also link to an open issue here)
The deprecation strategy is not specified.

What is the new behavior (if this is a feature change)?
The deprecation strategy is specified.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

Other information:

Fixes #15282

Copy link
Contributor

@Narretz Narretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor improvements in the added text.
I noticed that we basically don't talk about deprecation in the rest of the FAQ. Maybe we should add this to the section about the versioning strategy, and add this new deprecation section as a subsection?

@@ -130,6 +130,15 @@ AngularJS 1.3 only supports jQuery 2.1 or above. jQuery 1.7 and newer might work
but we don't guarantee that.


### When will the deprecated features be removed from the library?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When are will the deprecated features be ...

@@ -130,6 +130,15 @@ AngularJS 1.3 only supports jQuery 2.1 or above. jQuery 1.7 and newer might work
but we don't guarantee that.


### When will the deprecated features be removed from the library?
Most of the time we remove a deprecated feature in a next minor bump. For example, the `preAssignBindingsEnabled`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor version bump

@@ -130,6 +130,15 @@ AngularJS 1.3 only supports jQuery 2.1 or above. jQuery 1.7 and newer might work
but we don't guarantee that.


### When will the deprecated features be removed from the library?
Most of the time we remove a deprecated feature in a next minor bump. For example, the `preAssignBindingsEnabled`
`$compileProvider` method was defined in AngularJS `1.5.10`, deprecated in `1.6` and will be removed in `1.7`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to change this when 1.7.0 is released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe it'd be better to put sth else here, preferably something where we adhered to this strategy. :)

@mgol
Copy link
Member Author

mgol commented Mar 15, 2017

Maybe we should add this to the section about the versioning strategy, and add this new deprecation section as a subsection?

Makes sense.

@mgol mgol force-pushed the faq-deprecation branch from 8fb171b to 7343f82 Compare March 15, 2017 18:10
@mgol
Copy link
Member Author

mgol commented Mar 15, 2017

@Narretz PR updated, PTAL.

I amended the commit as the diff wouldn't tell much anyway when the whole section is moved.

@petebacondarwin petebacondarwin merged commit ba2e0d3 into angular:master Mar 22, 2017
@mgol mgol deleted the faq-deprecation branch March 22, 2017 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that jqLite deprecations follow jQuery deprecation timeline
4 participants