Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($interpolate): typo #15817

Merged
merged 1 commit into from
Mar 15, 2017
Merged

docs($interpolate): typo #15817

merged 1 commit into from
Mar 15, 2017

Conversation

Xazzzi
Copy link
Contributor

@Xazzzi Xazzzi commented Mar 15, 2017

There was missing JS at line 141.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Docs only, example fix.

What is the current behavior? (You can also link to an open issue here)

Somewhat confusing:

var exp = $interpolate('Hello {{name | uppercase}}!');
expect(exp({name:'AngularJS'})).toEqual('Hello ANGULAR!');

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

There was mission `JS` at line 141.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Narretz
Copy link
Contributor

Narretz commented Mar 15, 2017

Thanks for the PR. Can you sign the CLA?

@Xazzzi
Copy link
Contributor Author

Xazzzi commented Mar 15, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Narretz Narretz merged commit 0c3620b into angular:master Mar 15, 2017
@Xazzzi Xazzzi deleted the patch-1 branch March 15, 2017 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants