Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

perf(ngOptions): prevent initial options repaiting #15811

Closed
wants to merge 1 commit into from
Closed

perf(ngOptions): prevent initial options repaiting #15811

wants to merge 1 commit into from

Conversation

pbr1111
Copy link
Contributor

@pbr1111 pbr1111 commented Mar 14, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.

What is the current behavior? (You can also link to an open issue here)
Refers to this issue: ngOptions slow performance in IE due to option rerendering

What is the new behavior (if this is a feature change)?
Now the options are loaded once when we create the <select ng-options> directive. Also, if we add an <option> element with an ng-if directive, it is not deleted now.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

Other information:
None.

Avoid double execution of `updateOptions()` method, which causes a complete repainting of all `<option>` elements.

Fixes #15801
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@pbr1111
Copy link
Contributor Author

pbr1111 commented Mar 14, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@pbr1111 pbr1111 closed this Mar 14, 2017
@pbr1111 pbr1111 deleted the patch branch March 14, 2017 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants