This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix newline bug in date-filter #15792
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahidshahin
approved these changes
Mar 11, 2017
|
？？ |
gkalpak
suggested changes
Mar 12, 2017
There was a problem hiding this comment.
Generally LGTM.
Can you please update the commit message to follow our guidelines? That helps when generating the changelog.
test/ng/filter/filtersSpec.js
Outdated
| @@ -504,6 +504,11 @@ describe('filters', function() { | |||
| expect(date(morning, 'yy/xxx')).toEqual('10/xxx'); | |||
| }); | |||
|
|
|||
| it('should allow newlines in format', function() { | |||
| expect(date(midnight, 'EEE\nMMM d\'\n\'yy/xxx\n')). | |||
| toEqual('Fri\nSep 3\n10/xxx\n'); | |||
There was a problem hiding this comment.
Nit: There is not need for this to be a new line.
ashsearle
force-pushed
the
fix-date-filter-newlines
branch
from
caad12b to
81c32f9
Compare
|
I've updated commit message, addressed code review comment, and added short sentence to documentation as discussed in the issue #15794 - I hope the wording's OK. |
gkalpak
approved these changes
Mar 13, 2017
gkalpak
pushed a commit
that referenced
this pull request
Mar 13, 2017
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting a date across 2 lines fails:
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
The date format is only processed up to the newline. i.e. as though the sample code was:
Producing:
What is the new behavior (if this is a feature change)?
The full date format string is processed, producing:
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information: