-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(ngAnimate): Improve Staggering config for animations #15743
Conversation
After console.log the output from the computeCachedCssStaggerStyles function I realized that I need set animation-duration to 0s and animation-delay on my stagger class as I am using animations instead of transitions.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just white-space changes
@@ -177,6 +177,9 @@ | |||
* /* As of 1.4.4, this must always be set: it signals ngAnimate | |||
* to not accidentally inherit a delay property from another CSS class */ | |||
* transition-duration: 0s; | |||
* /* if you are using animations instead of transitions you should configure as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the trailing whitespace in this line
@@ -177,6 +177,9 @@ | |||
* /* As of 1.4.4, this must always be set: it signals ngAnimate | |||
* to not accidentally inherit a delay property from another CSS class */ | |||
* transition-duration: 0s; | |||
* /* if you are using animations instead of transitions you should configure as follows: | |||
* animation-delay: 0.1s; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the trailing whitespace in this line
After console.log the output from the computeCachedCssStaggerStyles function I realized that I need set animation-duration to 0s and animation-delay on my stagger class as I am using animations instead of transitions.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: