This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b345bf
to
429fdc8
Compare
This is the test that fails: angular.js/test/ngMock/angular-mocksSpec.js Lines 949 to 955 in 4d43ee3
In Safari 10.0.1, this test fails if the test file uses "use strict". Maybe this was fixed in 10.3? Here's a plunkr to test: http://plnkr.co/edit/GD0CeGnzuYa1NHIEcj65?p=preview |
Safari 10 fails here:
|
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Oct 18, 2017
Previously, we used fixed versions that became outdated quickly for FF and Chrome. Safari currently still has failures, see angular#15717
Narretz
added a commit
that referenced
this pull request
Oct 18, 2017
Previously, we used fixed versions that became outdated quickly for FF and Chrome. Safari 10/11 is not included because during the latest test there were failures, see #15717 Jasmine is fixed to 2.5.2 because 2.6.0+ is not compatible with the suite: #15927 (comment) Closes #15927
Narretz
added a commit
that referenced
this pull request
Oct 19, 2017
Previously, we used fixed versions that became outdated quickly for FF and Chrome. Safari 10/11 is not included because during the latest test there were failures, see #15717 Jasmine is fixed to 2.5.2 because 2.6.0+ is not compatible with the suite: #15927 (comment) Closes #15927
Added on master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.