This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test($http): ensure json deserialization errors are forwarded to erro… #15689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r handler Since angular@e13eeab, errors thrown from onFulfilled and onRejected handlers are passed to the regular http error handlers. Before this, JSON deserialization errors lead to hard application errors, and could not be handled by application code. This behavior was introduced in angular@7b6c1d0, and originally, a malformed JSON string was forwarded as the data to the http success response handler. This commit adds a specifc test case, even though the behavior is unlikely to break in the future without a change in the $q rejection handling. Related angular#11433
Narretz
added a commit
that referenced
this pull request
Feb 8, 2017
…r handler Since e13eeab, errors thrown from onFulfilled and onRejected handlers are passed to the regular http error handlers. Before this, JSON deserialization errors lead to hard application errors, and could not be handled by application code. This behavior was introduced in 7b6c1d0, and originally, a malformed JSON string was forwarded as the data to the http success response handler. This commit adds a specifc test case, even though the behavior is unlikely to break in the future without a change in the $q rejection handling. Related #11433 Closes #15689
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
…r handler Since angular@e13eeab, errors thrown from onFulfilled and onRejected handlers are passed to the regular http error handlers. Before this, JSON deserialization errors lead to hard application errors, and could not be handled by application code. This behavior was introduced in angular@7b6c1d0, and originally, a malformed JSON string was forwarded as the data to the http success response handler. This commit adds a specifc test case, even though the behavior is unlikely to break in the future without a change in the $q rejection handling. Related angular#11433 Closes angular#15689
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r handler
Since e13eeab,
errors thrown from onFulfilled and onRejected handlers are passed to the regular http
error handlers. Before this, JSON deserialization errors lead to hard application errors, and could
not be handled by application code. This behavior was introduced in 7b6c1d0, and originally, a malformed JSON string was forwarded
as the data to the http success response handler.
This commit adds a specifc test case, even though the behavior is unlikely to break in the future without
a change in the $q rejection handling.
Related #11433