This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($window): allow $window to be mocked in unit tests #15686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
suggested changes
Feb 7, 2017
src/ng/jsonpCallbacks.js
Outdated
| @@ -11,7 +11,7 @@ | |||
| */ | |||
| var $jsonpCallbacksProvider = /** @this */ function() { | |||
| this.$get = ['$window', function($window) { | |||
| var callbacks = $window.angular.callbacks; | |||
| var callbacks = $window.angular ? $window.angular.callbacks : {}; | |||
There was a problem hiding this comment.
Actually, I think it makes more sense to just use angular directly:
- var callbacks = $window.angular.callbacks;
+ var callbacks = angular.callbacks;
mattlewis92
force-pushed
the
fix-mocking-window
branch
from
dd8efbf to
fffb1bd
Compare
|
@gkalpak done 😄 |
gkalpak
reviewed
Feb 7, 2017
src/ng/jsonpCallbacks.js
Outdated
| @@ -10,8 +10,8 @@ | |||
| * how they vary compared to the requested url. | |||
| */ | |||
| var $jsonpCallbacksProvider = /** @this */ function() { | |||
| this.$get = ['$window', function($window) { | |||
| var callbacks = $window.angular.callbacks; | |||
| this.$get = [function() { | |||
There was a problem hiding this comment.
We don't need the [...] now. It can be just this.$get = function() {...
mattlewis92
force-pushed
the
fix-mocking-window
branch
from
fffb1bd to
c5f47a9
Compare
|
CI failure is a flake - the API limit on saucelabs has been hit |
mattlewis92
force-pushed
the
fix-mocking-window
branch
from
c5f47a9 to
fca0638
Compare
gkalpak
approved these changes
Feb 8, 2017
gkalpak
pushed a commit
that referenced
this pull request
Feb 8, 2017
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Feb 27, 2017
Adjust session tests for this: angular/angular.js#15686, should be able to remove in next angular release
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Mar 6, 2017
Adjust session tests for this: angular/angular.js#15686, should be able to remove in next angular release
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Mar 15, 2017
Adjust session tests for this: angular/angular.js#15686, should be able to remove in next angular release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
#15685
What is the new behavior (if this is a feature change)?
N/A
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information: