Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add casts to avoid some 'non-existent property' warnings from Closure… #15672

Closed
wants to merge 1 commit into from
Closed

Conversation

dimvar
Copy link
Contributor

@dimvar dimvar commented Feb 2, 2017

… Compiler.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

@dimvar
Copy link
Contributor Author

dimvar commented Feb 2, 2017

Googler here. This PR is required for an internal cleanup. @IgorMinar advised to send PR instead of submitting internally.

@gkalpak
Copy link
Member

gkalpak commented Feb 2, 2017

Which branches does this need to go in?

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange to me that these are the only places creating warnings (but it is probably because I am not very familiar with Closure Compiler).

@dimvar
Copy link
Contributor Author

dimvar commented Feb 2, 2017

Internally it's v1_5, so any branches that correspond to that.

@IgorMinar
Copy link
Contributor

LGTM. can we please get this merged to master soon and cherry-picked to v1.5.x to unblock an internal refactoring? Thanks!

@gkalpak gkalpak closed this in 1558128 Feb 2, 2017
gkalpak pushed a commit that referenced this pull request Feb 2, 2017
gkalpak pushed a commit that referenced this pull request Feb 2, 2017
@gkalpak
Copy link
Member

gkalpak commented Feb 2, 2017

Done

ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants