Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs app style updates #15670

Merged
merged 2 commits into from
Feb 15, 2017
Merged

docs app style updates #15670

merged 2 commits into from
Feb 15, 2017

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Feb 2, 2017

This updates the docs app to the new header style found on angularjs.org.

I've also taken the liberty to update the menu entries on the doc site - pending approval I'll update the org site, too (would fix #14351)

And fixes #14963

Notable differences between org / docs:

  • search icon
  • font family / weight (should we update?)
  • no drop shadow on navbar because there's a secondary bar on docs

Notable differences between docs old / new:

  • mobile: the top header + search are fixed, sub header is relative (previously all relative)
  • mobile search close icon has moved over the search bar, because I had some problems giving it it's previous position while keeping the search results scrollable (oh my)

Implementation notes:

  • angular-topnav.css is included as is from org site
  • several overrides necessary because org uses bootstrap 2 / docs uses bs 3 (oh my)
  • org site uses one breakpoint at 800px, docs uses one at 768 and one at 992. I tested it and it doesn't affect the common screen sizes

Future work:

  • clean up the css and maybe implement sass for the docs app

Screens:

fireshot screen capture 014 - angularjs_ api_ api reference - localhost_8000_build_docs_api desktop dropdown open
fireshot screen capture 015 - angularjs_ api_ api reference - localhost_8000_build_docs_api desktop search
fireshot screen capture 016 - angularjs_ api_ api reference - localhost_8000_build_docs_api phone dropdown
fireshot screen capture 017 - angularjs_ api_ api reference - localhost_8000_build_docs_api phone search

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't serve it locally, but the code and the screenshots look very good 😃

<li><a href="http://groups.google.com/group/angular">Mailing List</a></li>
<li><a href="http://webchat.freenode.net/?channels=angularjs&uio=d4">IRC</a></li>
<li><a href="https://gitter.im/angular/angular.js">Gitter</a></li>
<li><a href="https://twitter.com/#!/angular">Twitter</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😃 (The #!/ could be dropped: https://twitter.com/angular)

@Narretz
Copy link
Contributor Author

Narretz commented Feb 2, 2017

Tests have been fixed

@petebacondarwin petebacondarwin removed this from the 1.6.2 milestone Feb 6, 2017
@gkalpak gkalpak added this to the Backlog milestone Feb 9, 2017
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please make the same menu change as with the angularjs.org menu (faq/tutorial swap).

thanks!

Narretz added a commit to Narretz/angular.js that referenced this pull request Feb 15, 2017
Also adds a new fixed strip / bar about the AngularJS version

Closes angular#14963
Closes angular#15670
Also adds a new fixed strip / bar about the AngularJS version

Closes angular#14963
Closes angular#15670
They are now in the same order as angularjs.org

Closes angular#14351
@Narretz Narretz merged commit 62494ba into angular:master Feb 15, 2017
Narretz added a commit that referenced this pull request Feb 15, 2017
Also adds a new fixed strip / bar about the AngularJS version

Closes #14963
Closes #15670
Narretz added a commit that referenced this pull request Feb 16, 2017
Also adds a new fixed strip / bar about the AngularJS version

Closes #14963
Closes #15670
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Also adds a new fixed strip / bar about the AngularJS version

Closes angular#14963
Closes angular#15670
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logos out of date [mis-orgnized] different menus on same website: https://angularjs.org/
5 participants