This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
reviewed
Feb 2, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't serve it locally, but the code and the screenshots look very good 😃
<li><a href="http://groups.google.com/group/angular">Mailing List</a></li> | ||
<li><a href="http://webchat.freenode.net/?channels=angularjs&uio=d4">IRC</a></li> | ||
<li><a href="https://gitter.im/angular/angular.js">Gitter</a></li> | ||
<li><a href="https://twitter.com/#!/angular">Twitter</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 😃 (The #!/
could be dropped: https://twitter.com/angular
)
Tests have been fixed |
IgorMinar
approved these changes
Feb 15, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please make the same menu change as with the angularjs.org menu (faq/tutorial swap).
thanks!
8802869
to
41a4f4a
Compare
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Feb 15, 2017
Also adds a new fixed strip / bar about the AngularJS version Closes angular#14963 Closes angular#15670
Also adds a new fixed strip / bar about the AngularJS version Closes angular#14963 Closes angular#15670
They are now in the same order as angularjs.org Closes angular#14351
41a4f4a
to
f4791a0
Compare
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Also adds a new fixed strip / bar about the AngularJS version Closes angular#14963 Closes angular#15670
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the docs app to the new header style found on angularjs.org.
I've also taken the liberty to update the menu entries on the doc site - pending approval I'll update the org site, too (would fix #14351)
And fixes #14963
Notable differences between org / docs:
Notable differences between docs old / new:
Implementation notes:
Future work:
Screens: