This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($parse): Make sure ES6 object computed property to be watched #15637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the missing watches for ES6 object property which added in angular#14407
gkalpak
reviewed
Jan 24, 2017
| it('should watch ES6 object computed property changes', function() { | ||
| var count = 0; | ||
| var values = []; | ||
| var firstValue = {'undefined': true}; |
There was a problem hiding this comment.
This doesn't seem necessary. I think it's better to inline the object.
| var values = []; | ||
| var firstValue = {'undefined': true}; | ||
|
|
||
| scope.$watch('{[a]: true}', function(val, oldVal) { |
|
@gkalpak because I'm using v1.5.x now, so I just submit this PR to v1.5.x . |
|
@kindy we are branching and merging bug fixes from / to master and backport them manually to 1.5.x, so yes a PR that branches from master is preferred. Just open a new one with the updated code. |
|
@lgalfaso can you help review this PR? |
|
LGTM, *@gkalpak can you please merge this?*
|
|
@kindy, can you please rebase this on master? |
3 tasks
|
Thx! Closing in favor of #15678. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the missing watches for ES6 object property which added in #14407
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
$scope.$watchcan not work as expected.What is the new behavior (if this is a feature change)?
$scope.$watchworks (NOT a feature change)Does this PR introduce a breaking change?
NO
Please check if the PR fulfills these requirements
Other information: