Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor($interpolate): remove unnecessary else #15575

Merged
merged 2 commits into from
Jan 5, 2017

Conversation

Nikhil22
Copy link
Contributor

@Nikhil22 Nikhil22 commented Jan 4, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Cleaner code.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ghost
Copy link

ghost commented Jan 4, 2017

I signed it

} else {
return endSymbol;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a trailing space here. Can you please remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has been removed now

@Narretz
Copy link
Contributor

Narretz commented Jan 4, 2017

Can you please update the commit message to refactor($interpolate): remove unnecessary else ?

@Nikhil22 Nikhil22 changed the title removed unnecessary else statements removed unnecessary else Jan 4, 2017
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 4, 2017
@Nikhil22 Nikhil22 changed the title removed unnecessary else remove unnecessary else Jan 4, 2017
@Nikhil22 Nikhil22 changed the title remove unnecessary else refactor($interpolate): remove unnecessary else Jan 4, 2017
@Narretz Narretz merged commit c00903b into angular:master Jan 5, 2017
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants