Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(tutorial/13 - REST and Custom Services): added ngRoute dependanc… #15521

Closed
wants to merge 1 commit into from
Closed

Conversation

peterneave
Copy link
Contributor

Omitted the existing ngRoute dependency.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.

What is the current behavior? (You can also link to an open issue here)
The tutorial user would follow the documentation and find that routing no longer works for step 13.

What is the new behavior (if this is a feature change)?
The tutorial user would follow the documentation and find that routing still works for step 13.

Does this PR introduce a breaking change?
Should have no effect as it is documentation.

Please check if the PR fulfills these requirements

Other information:

…y to phone-details

Tutorial instruction for phone detail missing ngRoute dependency.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@peterneave
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Dec 19, 2016

Good catch! Thx 👍

@gkalpak gkalpak self-assigned this Dec 19, 2016
@gkalpak gkalpak closed this in 15d07c0 Dec 19, 2016
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants