This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($interval): improve fn description #15503
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
suggested changes
Dec 13, 2016
| @@ -33,7 +33,8 @@ function $IntervalProvider() { | |||
| * appropriate moment. See the example below for more details on how and when to do this. | |||
| * </div> | |||
| * | |||
| * @param {function()} fn A function that should be called repeatedly. | |||
| * @param {function()} fn A function that should be called repeatedly. If no arguments are passed, | |||
| * the function is called with the current iteration. | |||
There was a problem hiding this comment.
Can you change it to something like:
If not additional arguments are passed (see below), the function is called with the current iteration count.
There was a problem hiding this comment.
Done, cee8801
If no additional arguments are passed, the function is called with the current iteration count.
gkalpak
approved these changes
Dec 13, 2016
gkalpak
pushed a commit
that referenced
this pull request
Dec 13, 2016
If no additional arguments are passed, the function is called with the current iteration count. Closes #15503
gkalpak
pushed a commit
that referenced
this pull request
Dec 13, 2016
If no additional arguments are passed, the function is called with the current iteration count. Closes #15503
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
If no additional arguments are passed, the function is called with the current iteration count. Closes angular#15503
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update:
If no arguments were specified, angular passes the current iteration to the funtion (here)
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements