This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($rootScope): correctly propagate async changes after local $digest()
#15501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st()` Previously, if an async task was scheduled (via `$evalAsync()`) on a scope and `$digest()` happened to be called on another, unrelated scope (local digest), then the `asyncQueue` would be drained but `$rootScope.$digest()` would not be called (potentially preventing the changes to propagate correctly through the app). This commit fixes it by keeping track on whether `$digest()` has been called on `$rootScope` or not and call `$rootScope.$digest()` if necessary (even if the `asyncQueue` has been drained by a local `$digest()`). Fixes angular#15127 Closes angular#15494
3 tasks
dcherman
reviewed
Dec 12, 2016
| @@ -799,6 +799,10 @@ function $RootScopeProvider() { | |||
| } | |||
| asyncQueue.length = 0; | |||
|
|
|||
| if (this === $rootScope) { | |||
There was a problem hiding this comment.
This should probably be moved out of the while dirty loop since it's not necessary for it to be there
There was a problem hiding this comment.
I wanted to put this as close as possible to the point where we were certain that the asyncQueue has been fully processed. In 99.9% of the cases it won't make any difference if this is moved out of the look, so I am fine moving it.
|
Thinking it over, I think #15494 (even if not perfect) is a better alternative. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
If an async task is scheduled (via
$evalAsync()) on a scope and$digest()happens to be called on another, unrelated scope (local digest), then theasyncQueuewill be drained but$rootScope.$digest()will not be called (potentially preventing the changes to propagate correctly through the app).See #15127.
What is the new behavior (if this is a feature change)?
Angular keeps track on whether
$digest()has been called on$rootScopeor not and calls$rootScope.$digest()if necessary (even if theasyncQueuehas been drained by a local$digest()).Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
This is a more targeted alternative to #15494.
Fixes #15127.