This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModelOptions): work correctly when on the template of replace directives
#15493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directives Previously, in order for `ngModel` and `ngModelOptions` to work correctly together, the latter's pre-linking function should be run before the former's pre-linking function. This was typically what happened, except when `ngModel` was used on an element which also had a `replace` directive, whose template included `ngModelOptions`. In that case, the order was reversed. This commit fixes it by moving the initialization logic of `ngModelOptions` from its pre-linking function to its controller's `$onInit()` lifecycle hook. Fixes angular#15492
|
On the surface I like the look of this! I need to spend some time tomorrow checking it. |
petebacondarwin
approved these changes
Dec 12, 2016
| optionsCtrl.$options = parentOptions.createChild(scope.$eval(attrs.ngModelOptions)); | ||
| } | ||
| } | ||
| require: {parentOptionsCtrl: '?^^ngModelOptions'}, |
There was a problem hiding this comment.
I think the reason why I moved it to the pre-link function is because this feature of requiring directly onto the controller was either not available or very new.
There was a problem hiding this comment.
IIRC this is the first occurrence of this feature in Angular's codebase 🏋️
| } | ||
| NgModelOptionsController.prototype = { | ||
| $onInit: function() { | ||
| var parentCtrl = this.parentOptionsCtrl; |
There was a problem hiding this comment.
given that we can name the binding anything we like why not just call it parentCtrl and then there would be very little motivation for this line any more.
…eplace` directives
petebacondarwin
approved these changes
Dec 12, 2016
gkalpak
added a commit
that referenced
this pull request
Dec 12, 2016
… directives Previously, in order for `ngModel` and `ngModelOptions` to work correctly together, the latter's pre-linking function should be run before the former's pre-linking function. This was typically what happened, except when `ngModel` was used on an element which also had a `replace` directive, whose template included `ngModelOptions`. In that case, the order was reversed. This commit fixes it by moving the initialization logic of `ngModelOptions` from its pre-linking function to its controller's `$onInit()` lifecycle hook. Fixes #15492 Closes #15493
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
… directives Previously, in order for `ngModel` and `ngModelOptions` to work correctly together, the latter's pre-linking function should be run before the former's pre-linking function. This was typically what happened, except when `ngModel` was used on an element which also had a `replace` directive, whose template included `ngModelOptions`. In that case, the order was reversed. This commit fixes it by moving the initialization logic of `ngModelOptions` from its pre-linking function to its controller's `$onInit()` lifecycle hook. Fixes angular#15492 Closes angular#15493
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
In order for
ngModelandngModelOptionsto work correctly together, the latter's pre-linking function should be run before the former's pre-linking function. This is typically what happens, except whenngModelis used on an element which also has areplacedirective, whose template includesngModelOptions. In that case, the order is reversed.See #15492 for more details.
What is the new behavior (if this is a feature change)?
The initialization logic of
ngModelOptionsis moved from its pre-linking function to its controller's$onInit()lifecycle hook. This way, it is always guaranteed to be run beforengModel's pre-linking function, even in thereplacescenario mentioned above.Does this PR introduce a breaking change?
Maybe.
There is no breaking change wrt 1.5.x (where the initialization of
ngModelOptionsused to take place in the controller itself), but wrt to 1.6.0 the following usecase will no longer be possible:A sibling directive to
ngModelOptions, let's call itfoocould be modifying the model options definition (e.g.ng-model-options="modelOptionsDefinition") in its$onInit()lifecycle hook. If thefoodirective had a lower priority thatngModelOptions, then it will no longer work after this PR, since its$onInit()method will be called afterngModelOptionsis initialized.(This can be worked around by changing the priority of
footo be higher thanngModelOptionsor by overwritingngModelOptions#$optionsfromfoo#$onInit().Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
Fixes #15492.