Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngMessageExp): Better description #15486

Closed
wants to merge 2 commits into from
Closed

docs(ngMessageExp): Better description #15486

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f26eea
docs(ngMessageExp): Better description
spaceribs Dec 9, 2016
7b79a7b
Updating changes per feedback
spaceribs Dec 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/ngMessages/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,10 +629,8 @@ angular.module('ngMessages', [], function initAngularHelpers() {
* @scope
*
* @description
* `ngMessageExp` is a directive with the purpose to show and hide a particular message.
* For `ngMessageExp` to operate, a parent `ngMessages` directive on a parent DOM element
* must be situated since it determines which messages are visible based on the state
* of the provided key/value map that `ngMessages` listens on.
* `ngMessageExp` is the same as {@link module:ngMessage `ngMessage`} but instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be directive:ngMessage or something (instead of module:ngMessage)?

* of a DOM attribute, accepts an expression to be evaluated for the message key.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"DOM attribute" isn't correct. How about "static value"?

*
* @usage
* ```html
Expand Down