Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update external-resources.ngdoc #15480

Closed
wants to merge 1 commit into from

Conversation

amandeepmittal
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
General Resource Update

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

No

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

add AngularJS in Action Book

add AngularJS in Action Book
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@amandeepmittal
Copy link
Contributor Author

I signed it!

@gkalpak
Copy link
Member

gkalpak commented Dec 9, 2016

@googlebot doesn't seem to think so. Have you verified that the email address you signed it with is what appears on the commits?

@gkalpak gkalpak added this to the Purgatory milestone Dec 9, 2016
@amandeepmittal
Copy link
Contributor Author

Yes, I did.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 9, 2016
@gkalpak gkalpak closed this in d05f894 Dec 9, 2016
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants