This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngOptions): ignore comment nodes when removing 'selected' attribute #15456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #15454 |
|
LGTM |
| @@ -452,6 +452,7 @@ var ngOptionsDirective = ['$compile', '$document', '$parse', function($compile, | |||
| var removeEmptyOption = function() { | |||
| if (!providedEmptyOption) { | |||
| emptyOption.remove(); | |||
| // Empty nodes with non-rendered ngIf can be comment nodes | |||
There was a problem hiding this comment.
it isn't only ngIf that would replace it with a comment, any element transclusion directive, sich as ngSwitch, ngRepeat etc. would also do it. So perhaps the comment should be something along the lines of
// Empty options may be comment nodes if they have been removed by
// transclude directives such as `ngIf`
|
@Narretz - Please do land and forward port to 1.6 |
Narretz
force-pushed
the
fix-ngoptions-empty-ngif-rebased
branch
from
fffc646 to
860cb61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix (regression)
What is the current behavior? (You can also link to an open issue here)
When an empty option has ngIf on it in an ngOptions select, and the ngIf expression is false, then
an error is thrown, because we try to remove the "selected" attribute from the ngIf comment node.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
[ ] Docs have been added / updated (for bug fixes / features)Other information:
The logic is different in master, and the bug should not be happening there.The same bug exists on master