This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(ngAnimate): cleanup vendor prefixes handling in tests #15406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are they even prefixed anymore in current Chrome? Couldn't we just get rid of them? |
|
It's not about Chrome but Android Browser. Which we should start testing on On Thu, 17 Nov 2016 at 18:33, Martin Staffa [email protected]
|
1. Change all transition/transform/animation-related ss.addRule to ss.addPossiblyPrefixedRule to account for the -webkit- prefix. 2. Remove manually added -webkit-prefixed rules in favor of automatically handling them in ss.addPossiblyPrefixedRule. Closes angular#15406
mgol
force-pushed
the
animate-spec-cleanup
branch
from
41a5b43 to
36901c6
Compare
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
1. Change all transition/transform/animation-related ss.addRule to ss.addPossiblyPrefixedRule to account for the -webkit- prefix. 2. Remove manually added -webkit-prefixed rules in favor of automatically handling them in ss.addPossiblyPrefixedRule. Closes angular#15406
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore
What is the current behavior? (You can also link to an open issue here)
-webkit-prefixed rules are sometimes added manually in ngAnimate tests and sometimes not accounted for at all.
What is the new behavior (if this is a feature change)?
ss.addPossiblyPrefixedRuleis used where applicable, automatically handling the-webkit-prefix. Manually added prefixes have been removed.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
ss.addPossiblyPrefixedRule to account for the -webkit- prefix.
handling them in ss.addPossiblyPrefixedRule.