-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix(ngMock/$controller): respect $compileProvider.preAssignBindingsEnabled()
#15395
fix(ngMock/$controller): respect $compileProvider.preAssignBindingsEnabled()
#15395
Conversation
LGTM as long as Travis is happy. |
b7889a5
to
3e354dd
Compare
It turned out |
Travis seems happy. Feel free to merge. |
…nabled()` Fixes angular#15387 Closes angular#15395
…nabled()` Fixes angular#15387 Closes angular#15395
…nabled()` Fixes angular#15387 Closes angular#15395
…nabled()` Fixes angular#15387 Closes angular#15395
…nabled()` Fixes angular#15387 Closes angular#15395
This change ended up on |
Yes, this was intentional. This is complementary to the new |
…nabled()` Fixes angular#15387 Closes angular#15395
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
ngMock
's$controller
service always pre-assigns bindings (if available), regardless of the value of$compileProvider.preAssignBindingsEnabled()
. This may cause false positives or negatives in tests.See #15387.
What is the new behavior (if this is a feature change)?
ngMock
's$controller
service does not pre-assign bindings (if available), unless$compileProvider.preAssignBindingsEnabled()
returns true.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
Fixes #15387