Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(angular.isArray): Document that isArray is an alias #15383

Closed
wants to merge 1 commit into from

Conversation

graingert
Copy link
Contributor

What kind of change does this PR introduce? docs update

Does this PR introduce a breaking change?
no

Please check if the PR fulfills these requirements

@Narretz
Copy link
Contributor

Narretz commented Nov 10, 2016

This is technically an implementation detail, why do you want to document this?

@graingert
Copy link
Contributor Author

@Narretz so users can make an informed decision about whether to use Array.isArray or angular.isArray

@gkalpak
Copy link
Member

gkalpak commented Nov 14, 2016

For the record, I agree this is an implementation detail (was different in the past and may change in the future - not likely but possible). We don't document other helper/function implementations to allow informed decisions. Just saying...

petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants