This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(angular.isArray): Document that isArray is an alias #15383
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is technically an implementation detail, why do you want to document this? |
@Narretz so users can make an informed decision about whether to use Array.isArray or angular.isArray |
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 10, 2016
For the record, I agree this is an implementation detail (was different in the past and may change in the future - not likely but possible). We don't document other helper/function implementations to allow informed decisions. Just saying... |
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 23, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 24, 2016
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? docs update
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements