docs(CONTRIBUTING.md): add note about scope wildcard #15326
Conversation
| @@ -249,6 +249,8 @@ Must be one of the following: | |||
| The scope could be anything specifying place of the commit change. For example `$location`, | |||
| `$browser`, `$compile`, `$rootScope`, `ngHref`, `ngClick`, `ngView`, etc... | |||
|
|
|||
| You can use `*` if there isn't a more fitting scope. | |||
There was a problem hiding this comment.
According to my (unofficial) understanding, I would say * is for when the change affects more than a single scope.
jsoref
force-pushed
the
contributing-scope
branch
from
f8571b6 to
bd6cd16
Compare
|
Wasn't there a goodle doc where these guidelines originate from? Here: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit# It doesn't mention the asterisks or leaving out the scope, maybe it's not the latest version? |
|
@Narretz: @stevemao talked about that url in #12032 (comment) when Further, If there's a document like that, CONTRIBUTING.md should reference it too... |
I thought this was true... I don't think this is in any doc yet. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
no hint that
*is a valid scope -- it hints you could omit the(...)bit, but most commits of late don'tWhat is the new behavior (if this is a feature change)?
documentation of
*Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
Other information: