Changes test #15311

petebacondarwin · 2016-10-24T20:41:52Z

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Other information:

gkalpak · 2016-10-25T06:54:45Z

CHANGELOG.md

@@ -1,3 +1,971 @@
+<a name="1.6.0-rc.0"></a>
+# 1.6.0-rc.0 bracing-vortex (Mon Oct 24 2016)


Not sure if the different date format was intentional, but I liked the old one better 😁

gkalpak · 2016-10-25T07:01:27Z

CHANGELOG.md

+- **jqLite:**
+  - implement `jqLite(f)` as alias to `jqLite(document).ready(f)` (369fb7f4f73664bcdab0350701552d8bef6f605e)
+  - don&#39;t throw for elements with missing `getAttribute` (4e6c14dcae4a9a30b3610a288ef8d20db47c4417)
+  - don&#39;t remove a boolean attribute for `.attr(attrName, &#39;&#39;)` (3faf4505732758165083c9d21de71fa9b6983f4a)


' doesn't render as ' inside backticks.

gkalpak · 2016-10-25T07:02:06Z

CHANGELOG.md

+  - don&#39;t throw for elements with missing `getAttribute` (4e6c14dcae4a9a30b3610a288ef8d20db47c4417)
+  - don&#39;t remove a boolean attribute for `.attr(attrName, &#39;&#39;)` (3faf4505732758165083c9d21de71fa9b6983f4a)
+  - remove the attribute for `.attr(attribute, null)` (4e3624552284d0e725bf6262b2e468cd2c7682fa)
+  - return `[]` for `.val()` on `&lt;select multiple&gt;` with no selection (d882fde2e532216e7cf424495db1ccb5be1789f8)


</> do not render as </> inside backticks.

gkalpak · 2016-10-25T07:04:55Z

CHANGELOG.md

+- **$route:** implement `resolveRedirectTo` (e9865654b39c71be71034c38581a8c7bd16bc716 #5150)
+- **input[radio]:** allow `ng-trim` to work for `input[type=radio]` (47724baffe050269385b3481e9a9cf4ab3944b4b)
+- **$q:** report promises with non rejection callback (c9dffde1cb167660120753181cb6d01dc1d1b3d0)
+- **$location:** default hashPrefix to `&#39;!&#39;` (aa077e81129c740041438688dff2e8d20c3d7b52 #13812)


' --> '
_{(Does changez converts ' to '?)}

gkalpak · 2016-10-25T07:05:55Z

CHANGELOG.md

+- **$animate:** listen for document visibility changes (d71dc2f5afec230711351e9f160873a41eb60597)
+- **injector:** cache the results of the native class detection check (5ceb5dbfa6d9b6d15232a1f5c767b2f431325948)
+- **$parse:** Inline constants (bd7d5f6345439aa2d1da708ffee20b4c565131d4)
+- **$compile:** use strict comparison for `controller === &#39;@&#39;` (bbd3db14f857aab996ad129f2f15ca6348e9fd9f)


' --> '

gkalpak · 2016-10-25T07:11:46Z

CHANGELOG.md

+/* 3 */
+elem.data()[&#39;foo-bar&#39;] = 1;
+elem.data()[&#39;fooBar&#39;] = 2;
+elem.data()[&#39;foo-bar&#39;]; // 1


These sections need to be wrapped in triple backticks, because all lines render on the same line.
(Also ' --> ' 😁)

Also, the last line should be elem.data('foo-bar'); // 1

gkalpak · 2016-10-25T07:13:34Z

CHANGELOG.md

+/* 3 */
+elem.data()[&#39;foo-bar&#39;] = 1;
+elem.data()[&#39;fooBar&#39;] = 2;
+elem.data()[&#39;foo-bar&#39;]; // 2


The last line should be elem.data('foo-bar'); // 1

gkalpak · 2016-10-25T07:14:25Z

CHANGELOG.md

+var bgColor = elem.css(&#39;background:color&#39;);
+var bgColor = elem.css(&#39;background-color&#39;);
+var bgColor = elem.css(&#39;background--color&#39;);
+var bgColor = elem.css(&#39;backgroundColor&#39;);


Wrap in triple backticks. (Here and below.)

gkalpak · 2016-10-25T19:44:01Z

CHANGELOG.md

@@ -1,3 +1,1038 @@
+<a name="1.6.0-rc.0"></a>
+# 1.6.0-rc.0 bracing-vortex (Tue Oct 25 2016)


Is the date format change intentional?

It was easier to do it this way. Does it matter?

Easier? To be clear I am talking about displaying the date as Tue Oct 25 2016 vs 2016-10-25.

We've been using the YYYY-MM-DD format in previous releases. I find it easier to read (especially since Oct 25 2016 is locale-specific - e.g. some (sane 😛) locales put the day before the month) and I guess most people don't care what day of week it was 😛

But it's just a slight preference of mine. Not a biggy. Leaving it up to you.
_{(But we should stick with the format we choose for future releases.)}

Easier - as in easier for me to write the nunjucks template :-)
OK, I'll fix this.

gkalpak · 2016-10-25T19:48:39Z

CHANGELOG.md

+  - JSONP callback must be specified by `jsonpCallbackParam` config ([fb6634](https://github.com/angular/angular.js/commit/fb663418710736161a6b5da49c345e92edf58dcb) [#15161](https://github.com/angular/angular.js/issues/15161) [#11352](https://github.com/angular/angular.js/issues/11352))
+  - JSONP requests now require a trusted resource URL ([6476af](https://github.com/angular/angular.js/commit/6476af83cd0418c84e034a955b12a842794385c4) [#11352](https://github.com/angular/angular.js/issues/11352))
+- **ngModelOptions:** allow options to be inherited from ancestor `ngModelOptions` ([87a2ff](https://github.com/angular/angular.js/commit/87a2ff76af5d0a9268d8eb84db5755077d27c84c) [#10922](https://github.com/angular/angular.js/issues/10922))
+- **input:** add support for binding to `input[type=range]` (#14870) ([913016](https://github.com/angular/angular.js/commit/9130166767c4792c5d32d08a918fc7becf32c9a6) [#5892](https://github.com/angular/angular.js/issues/5892))


Make #14870 a link.

gkalpak · 2016-10-25T19:51:02Z

CHANGELOG.md

+/* 3 */
+elem.data()['foo-bar'] = 1;
+elem.data()['fooBar'] = 2;
+elem.data()['foo-bar']; // 1


This should be elem.data('foo-bar').

I thought I fixed this already...

Oh, I only fixed the "after" version

gkalpak · 2016-10-25T19:52:35Z

CHANGELOG.md

+- **feat(jqLite): remove the attribute for `.attr(attribute, null)` ([4e3624](https://github.com/angular/angular.js/commit/4e3624552284d0e725bf6262b2e468cd2c7682fa))**:
+
+Invoking `elem.attr(attributeName, null)` would set the
+`attributeName` atribute value to a string `&quot;null&quot;`, now it removes the


" --> "

Right! I had a problem with nunjucks escaping stuff. The tool is fixed but I manually updated this file and didn't catch them all.

gkalpak · 2016-10-25T19:52:59Z

CHANGELOG.md

+After:
+
+```
+elem.attr(attributeName, &quot;null&quot;);


" --> "

gkalpak · 2016-10-25T20:22:14Z

CHANGELOG.md

+or is being run on browsers that do not support HTML5 mode, and you have
+not specified your own hash-prefix then client side URLs will now contain
+a &quot;!&quot; prefix. For example, rather than `mydomain.com/#/a/b/c` will become
+`mydomain/#!/a/b/c`.


mydomain --> mydomain.com

gkalpak · 2016-10-25T20:24:47Z

CHANGELOG.md

+Due to the way that `input[type=range]` elements behave this feature modifies the behavior of such elements
+when bound to `ngModel`:
+
+- Like input[number], it requires the model to be a Number, and will set the model to a Number


input[number] --> input[number] (or else [number] is interpreted as link)

gkalpak · 2016-10-25T20:26:11Z

CHANGELOG.md

+    that prompts the browser to update the input value.
+  - ngMin / ngMax do not prompt the browser to update the values, as they don't set the attribute values.
+    Instead, they will set the min / max errors when appropriate
+- browsers that do not support input[range] (IE9) handle the input like a number input (with validation etc.)


input[range] --> input[range] (or else [number] is interpreted as link)

gkalpak · 2016-10-25T20:27:06Z

CHANGELOG.md

+when bound to `ngModel`:
+
+- Like input[number], it requires the model to be a Number, and will set the model to a Number
+- it supports setting the min/max values via the min/max and ngMin/ngMax attributes


Actually, we don't support ngMin/Max.

gkalpak · 2016-10-25T20:27:25Z

CHANGELOG.md

+    ngModel directive is initialized.
+  - this behavior is supported when the model changes and when the min/max attributes change in a way
+    that prompts the browser to update the input value.
+  - ngMin / ngMax do not prompt the browser to update the values, as they don't set the attribute values.


Actually, we don't support ngMin/Max.

gkalpak · 2016-10-26T10:23:29Z

CHANGELOG.md

+Please read the [Sandbox Removal Blog Post](http://angularjs.blogspot.com/2016/09/angular-16-expression-sandbox-removal.html).
+
+## Bug Fixes
+- **input:** fix `step` validation for `input[number]`/`input[type=range]` ([081d06](https://github.com/angular/angular.js/commit/081d06ffd15c2c6c539ce97b5eb63fa8e2403818) [#15257](https://github.com/angular/angular.js/issues/15257))


Since you are changing input[xyz] to input[type=xyz]: You missed one here (input[number]) 😃

gkalpak · 2016-10-26T10:29:26Z

CHANGELOG.md

+
+## Breaking Changes
+
+- **fix(jqLite): camelCase keys in `jqLite#data` ([fc0c11](https://github.com/angular/angular.js/commit/fc0c11db845d53061430b7f05e773dcb3fb5b860))**:


I find the previous format more clear (e.g. it is easier to spot what service/directive/... the BC is about), but I am fine either way. We should just decide what our format is and stick to it for future releases.

gkalpak · 2016-10-26T10:36:43Z

CHANGELOG.md

@@ -1,3 +1,1038 @@
+<a name="1.6.0-rc.0"></a>
+# 1.6.0-rc.0 bracing-vortex (Tue Oct 25 2016)


Easier? To be clear I am talking about displaying the date as Tue Oct 25 2016 vs 2016-10-25.

We've been using the YYYY-MM-DD format in previous releases. I find it easier to read (especially since Oct 25 2016 is locale-specific - e.g. some (sane 😛) locales put the day before the month) and I guess most people don't care what day of week it was 😛

But it's just a slight preference of mine. Not a biggy. Leaving it up to you.
_{(But we should stick with the format we choose for future releases.)}

googlebot added the cla: yes label Oct 24, 2016

gkalpak reviewed Oct 25, 2016

View reviewed changes

petebacondarwin mentioned this pull request Oct 25, 2016

docs: Things that need manual fixing in Changelog/Migration guide #15286

Closed

7 tasks

gkalpak suggested changes Oct 25, 2016

View reviewed changes

gkalpak suggested changes Oct 26, 2016

View reviewed changes

petebacondarwin added 2 commits October 26, 2016 17:50

chore(deps): add changez

491d23e

docs(CHANGELOG): add 1.6.0-rc.0 release notes

3c88c62

petebacondarwin force-pushed the changes-test branch from 9ee4648 to 3c88c62 Compare October 26, 2016 16:50

petebacondarwin merged commit 3c88c62 into angular:master Oct 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes test #15311

Changes test #15311

petebacondarwin commented Oct 24, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 26, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 25, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 25, 2016

petebacondarwin Oct 26, 2016

gkalpak Oct 26, 2016

gkalpak Oct 26, 2016

gkalpak Oct 26, 2016

		@@ -1,3 +1,971 @@
		<a name="1.6.0-rc.0"></a>
		# 1.6.0-rc.0 bracing-vortex (Mon Oct 24 2016)

		@@ -1,3 +1,1038 @@
		<a name="1.6.0-rc.0"></a>
		# 1.6.0-rc.0 bracing-vortex (Tue Oct 25 2016)


		## Breaking Changes

		- fix(jqLite): camelCase keys in `jqLite#data` ([fc0c11](https://github.com/angular/angular.js/commit/fc0c11db845d53061430b7f05e773dcb3fb5b860)):

Changes test #15311

Changes test #15311

Conversation

petebacondarwin commented Oct 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment