This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(doc-gen, docs-app): create plnkr examples with correct Angular … #15269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version When the docs are based on the snapshot, the plnkr examples must use the snapshot files from code.angularjs.org Fixes angular#15267
|
I didn't look at the deployment file in detail but appears to LGTM. Let's suck it and see! |
|
👍 The deployment file is basically copied from the index deplyoment file and only the cdn variable has been adjusted. So it should be good. |
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…version When the docs are based on the snapshot, the plnkr examples must use the snapshot files from code.angularjs.org Closes angular#15267 PR (angular#15269)
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…version When the docs are based on the snapshot, the plnkr examples must use the snapshot files from code.angularjs.org Closes angular#15267 PR (angular#15269)
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…version When the docs are based on the snapshot, the plnkr examples must use the snapshot files from code.angularjs.org Closes angular#15267 PR (angular#15269)
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…version When the docs are based on the snapshot, the plnkr examples must use the snapshot files from code.angularjs.org Closes angular#15267 PR (angular#15269)
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…version When the docs are based on the snapshot, the plnkr examples must use the snapshot files from code.angularjs.org Closes angular#15267 PR (angular#15269)
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
…version When the docs are based on the snapshot, the plnkr examples must use the snapshot files from code.angularjs.org Closes angular#15267 PR (angular#15269)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs-gen / app fix
What is the current behavior? (You can also link to an open issue here)
The plnkr examples include the latest stable Angular version instead of the snapshot version when opened from snapshot docs.
What is the new behavior (if this is a feature change)?
Fixes the plnkr examples generated from snapshot docs
Please check if the PR fulfills these requirements
[ ] Tests for the changes have been added (for bug fixes / features)[ ] Docs have been added / updated (for bug fixes / features)Other information:
…version
When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org
Fixes #15267