This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($rootScope.Scope): grammar #15263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
reviewed
Oct 13, 2016
| @@ -437,7 +437,7 @@ function $RootScopeProvider() { | |||
| * If any one expression in the collection changes the `listener` is executed. | |||
| * | |||
| * - The items in the `watchExpressions` array are observed via standard $watch operation and are examined on every | |||
| * call to $digest() to see if any items changes. | |||
| * call to $digest() to see if any items change. | |||
There was a problem hiding this comment.
This makes it sound as if the act of examining itself may cause the change. I think it is more clear to say: "if any item(s) changed"
There was a problem hiding this comment.
What if we put it this way?
The items in the watchExpressions array are observed via standard $watch operation. Their return values are examined for changes on every call to $digest.
There was a problem hiding this comment.
Works for me. I'll change it to what you suggested while merging.
|
@googlebot, could you please do your CLA thing? |
|
@thorn0, could you comment on the PR. Maybe that would trigger @googlebot. |
|
What's wrong with @googlebot? |
gkalpak
pushed a commit
that referenced
this pull request
Oct 14, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 23, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 24, 2016
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.