This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($parse): validate assignment lval in parser phase #15234
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - except of course for the use of double quotes :-) |
petebacondarwin
pushed a commit
that referenced
this pull request
Oct 10, 2016
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes #15234
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes angular#15234
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes angular#15234
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes angular#15234
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes angular#15234
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes angular#15234
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 23, 2016
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes #15234
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 24, 2016
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes #15234
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
The parser always threw an error in the case of an invalid left-value assignment but it was an unhelpful: ``` Cannot set property 'undefined' of undefined ``` This commit provides a more meaningful error message, so it is not a breaking change. Closes angular#15234
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix
What is the current behavior? (You can also link to an open issue here)
csp and non-csp are different when parsing an invalid lval
What is the new behavior (if this is a feature change)?
csp and non-csp are the same when parsing an invalid lval
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements