This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor(ngModelSpec): use valueFn over curry #15231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor ngModelSpec to use internal helper function `valueFn`. Use instead of multiple-defining a function called `curry`. Addresses a quick change mentioned in PR 15208 from Issue angular#14734
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Refactor ngModelSpec to use internal helper function `valueFn`. Use instead of multiple-defining a function called `curry`. PR (angular#15231) Addresses a quick change mentioned in PR 15208 from Issue angular#14734
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Refactor ngModelSpec to use internal helper function `valueFn`. Use instead of multiple-defining a function called `curry`. PR (angular#15231) Addresses a quick change mentioned in PR 15208 from Issue angular#14734
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Refactor ngModelSpec to use internal helper function `valueFn`. Use instead of multiple-defining a function called `curry`. PR (angular#15231) Addresses a quick change mentioned in PR 15208 from Issue angular#14734
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Refactor ngModelSpec to use internal helper function `valueFn`. Use instead of multiple-defining a function called `curry`. PR (angular#15231) Addresses a quick change mentioned in PR 15208 from Issue angular#14734
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Refactor ngModelSpec to use internal helper function `valueFn`. Use instead of multiple-defining a function called `curry`. PR (angular#15231) Addresses a quick change mentioned in PR 15208 from Issue angular#14734
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Refactor ngModelSpec to use internal helper function `valueFn`. Use instead of multiple-defining a function called `curry`. PR (angular#15231) Addresses a quick change mentioned in PR 15208 from Issue angular#14734
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor.
What is the current behavior? (You can also link to an open issue here)
Defines a
curryfunction, which is not needed because the internal helpervalueFndoes the exact same thing. See also this comment chain: PR 15208 CommentWhat is the new behavior (if this is a feature change)?
Nothing changes.
Does this PR introduce a breaking change?
Nope.
Please check if the PR fulfills these requirements
Other information:
Refactor ngModelSpec to use internal helper function
valueFn.Use instead of multiple-defining a function called
curry.Addresses a quick change mentioned in PR 15208 from Issue #14734