This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($controller): deprecate the use of $controllerProvider#allowGlobals #15230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are going to remove the feature in 1.7? |
|
I agree. The version when this is removed should go into the deprecated tag. @petebacondarwin can we render this nicely with dgeni? |
|
We should be able to tweak the dgeni templates. I'll take a look tomorrow |
| @@ -59,6 +59,9 @@ function $ControllerProvider() { | |||
| * @ngdoc method | |||
| * @name $controllerProvider#allowGlobals | |||
| * @description If called, allows `$controller` to find controller constructors on `window` | |||
| * | |||
| * @deprecated | |||
| * This method of finding controllers has been deprecated. This will be removed in a future version. | |||
There was a problem hiding this comment.
This will be removed in 1.7
jbedard
force-pushed
the
dep-allowglobal
branch
from
bf3628c to
6b76d9e
Compare
|
@petebacondarwin updated with a specific version |
gkalpak
reviewed
Oct 18, 2016
| @@ -59,6 +59,9 @@ function $ControllerProvider() { | |||
| * @ngdoc method | |||
| * @name $controllerProvider#allowGlobals | |||
| * @description If called, allows `$controller` to find controller constructors on `window` | |||
| * | |||
| * @deprecated | |||
| * This method of finding controllers has been deprecated. This will be removed in 1.7 | |||
jbedard
force-pushed
the
dep-allowglobal
branch
from
6b76d9e to
31603cf
Compare
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs
Does this PR introduce a breaking change?
puts the warning for a future one
Anything else that needs to be done to prepare for removing this in 1.7?