This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
feat($anchorScroll) Allow $anchorScroll to take a numeric input #15182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref angular#14680 Before the change : <div id="7"> $anchorScroll(7); Does not work After the change : <div id="7"> $anchorScroll(7); works
Ref angular#14680 Before the change : <div id="7"> $anchorScroll(7); Does not work After the change : <div id="7"> $anchorScroll(7); works
Thx for the PR 👍 (Feel free to ping me when you have pushed any changes, so I can take another look.) |
Ref angular#14680 Before the change : <div id="7"> $anchorScroll(7); Does not work After the change : <div id="7"> $anchorScroll(7); works
@gkalpak Hi gkalpak ! I've added two unit tests. One to check if $anchorScroll still works with a hash of type string. And another one to test the new behavior. :) |
LGTM |
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This allows `$anchorScroll(7)` to scroll to `<div id="7">` (although technically, the target ID is a string, not a number). Fixes angular#14680 Closes angular#15182
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This allows `$anchorScroll(7)` to scroll to `<div id="7">` (although technically, the target ID is a string, not a number). Fixes angular#14680 Closes angular#15182
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This allows `$anchorScroll(7)` to scroll to `<div id="7">` (although technically, the target ID is a string, not a number). Fixes angular#14680 Closes angular#15182
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This allows `$anchorScroll(7)` to scroll to `<div id="7">` (although technically, the target ID is a string, not a number). Fixes angular#14680 Closes angular#15182
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This allows `$anchorScroll(7)` to scroll to `<div id="7">` (although technically, the target ID is a string, not a number). Fixes angular#14680 Closes angular#15182
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
This allows `$anchorScroll(7)` to scroll to `<div id="7">` (although technically, the target ID is a string, not a number). Fixes angular#14680 Closes angular#15182
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Allow $anchorScroll to take a numeric input
Ref #14680
What is the new behavior (if this is a feature change)?
$anchorScroll can now take a numeric input :
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
Ref #14680
Before the change :
After the change :