This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($resource): pass options when binding default params
#15160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Resource.bind()`, which creates an new Resource class with the same propertiesexcept for the additional bound default parameters, was not passing the original Resource class' `options`, resulting in different behavior. This commit fixes it by passing the `options` when creating the new Resource class.
…efaults` + `options`)
|
LGTM as soon as Travis is happy |
gkalpak
added a commit
that referenced
this pull request
Sep 21, 2016
…efaults` + `options`) Closes #15160
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…efaults` + `options`) Closes angular#15160
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…efaults` + `options`) Closes angular#15160
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…efaults` + `options`) Closes angular#15160
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…efaults` + `options`) Closes angular#15160
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
…efaults` + `options`) Closes angular#15160
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 23, 2016
…efaults` + `options`) Closes #15160
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 24, 2016
…efaults` + `options`) Closes #15160
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
Resource.bind(), which creates an new Resource class with the same properties except for theadditional bound default parameters, was not passing the original Resource class'
options,resulting in different behavior.
What is the new behavior (if this is a feature change)?
The
optionsare passed when creating the new Resource class.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
This feature is undocumented. It might be a better idea to remove it altogether (although it does sounds useful). In any case, if we're keeping it, let's make it bug-free 😃
This PR also includes a couple of
$resourcerefactorings that don't change the behavior.