Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($q): replace "array" with "object" in tests for hash argument #15111

Closed
wants to merge 1 commit into from

Conversation

mohsen1
Copy link
Contributor

@mohsen1 mohsen1 commented Sep 8, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Sep 8, 2016

Good catch 😃
Can you please sign the CLA so we can merge this?

@gkalpak gkalpak added this to the Purgatory milestone Sep 8, 2016
@mohsen1 mohsen1 changed the title Fix typo in $q spec docs($q): replace "array" with "object" in tests for hash Sep 8, 2016
@mohsen1
Copy link
Contributor Author

mohsen1 commented Sep 8, 2016

Done!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 8, 2016
@mohsen1 mohsen1 changed the title docs($q): replace "array" with "object" in tests for hash docs($q): replace "array" with "object" in tests for hash argument Sep 8, 2016
@Narretz
Copy link
Contributor

Narretz commented Sep 8, 2016

@gkalpak Is the type "test" or "docs"?

@gkalpak
Copy link
Member

gkalpak commented Sep 8, 2016

Now it's docs 😛
I always have a hard time with these changes, but I think we've been labeling them as docs and since the commit message issue title says docs, let's roll with that 😄

@gkalpak gkalpak closed this in 51a2eb7 Sep 8, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants