This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): bindToController should work without controllerAs
#15110
+106
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we can decide between this and #15106 |
|
Yep, I didn't see #15106 |
|
Let's keep this one. It's more complete than #15106. |
|
Is there a way to restart Travis without pushing a new commit? |
3 tasks
|
There is 😄 |
| expect($rootScope.myCtrl).toBeUndefined(); | ||
| } else { | ||
| // The controller identifier was added to the containing scope! | ||
| // Should we allow this to happen? |
There was a problem hiding this comment.
Why not? It's their code, they are allowed to do things 😃
In any case, this is not related to this PR. Remove this comment and feel free to open a new issue about it if you feel it shouldn't happen.
There was a problem hiding this comment.
Just wasn't sure about it...
|
LGTM as long as Travis is happy (and unless someone can think of a good reason not to allow this). |
thorn0
force-pushed
the
bindToController_minus_controllerAs
branch
from
c2532c6 to
9037111
Compare
|
LGTM, please merge |
gkalpak
pushed a commit
that referenced
this pull request
Sep 16, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 23, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 24, 2016
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix
What is the current behavior? (You can also link to an open issue here)
see #15088
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements