Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

camelCase directive in html referenced as kebab-case, The kebab-case shall be camel-case #15051

Closed
wants to merge 1 commit into from

Conversation

rohitbind
Copy link

@rohitbind rohitbind commented Aug 23, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

In line no 71 and 72 camelCase is directive name and in HTML the it is said that it should be kebab-case where as it should be 'camel-case'.

I felt that beginners who is trying to learn from tutorial can get confused.

In line no 71 and 72 `camelCase` is directive name and in HTML the it is said that it should be kebab-case where as it should be 'camel-case'.

I felt that beginners who is trying to learn from tutorial can get confused.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rohitbind rohitbind changed the title docs(tutorial/3 - Components): describe your change... camelCase directive in html referenced as kebab-case, The kebab-case shall be camel-case Aug 23, 2016
@Narretz
Copy link
Contributor

Narretz commented Aug 23, 2016

Hm, I see the problem. We should use an example name for the component then, instead of camelCase, kebab-case, because the new example can also be confusing.

@rohitbind
Copy link
Author

Hi Narretz,
travis failed what could be the reason, I just edited the doc. Is there is any problem from my side?

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Aug 23, 2016

Thx for the PR, but this change is invalid. The used case is indeed called kebab-case.

@gkalpak gkalpak closed this Aug 23, 2016
@gkalpak
Copy link
Member

gkalpak commented Aug 23, 2016

I think it's best to add links to definitions of camel/kebab case.

@Narretz
Copy link
Contributor

Narretz commented Aug 23, 2016

The names are not the real component names. It's just to illustrate that when defining the component, you do it like this: myCustomComponent. And when using it in the template do: my-custom-component

gkalpak added a commit that referenced this pull request Aug 25, 2016
gkalpak added a commit that referenced this pull request Aug 25, 2016
@gkalpak
Copy link
Member

gkalpak commented Aug 25, 2016

cb31067 hopefully improves the explanation of casing.

@rohitbind
Copy link
Author

Thanks for accepting the suggestion 👍 :)

petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants