-
Notifications
You must be signed in to change notification settings - Fork 27.4k
camelCase directive in html referenced as kebab-case, The kebab-case shall be camel-case #15051
Conversation
In line no 71 and 72 `camelCase` is directive name and in HTML the it is said that it should be kebab-case where as it should be 'camel-case'. I felt that beginners who is trying to learn from tutorial can get confused.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Hm, I see the problem. We should use an example name for the component then, instead of camelCase, kebab-case, because the new example can also be confusing. |
Hi Narretz, |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Thx for the PR, but this change is invalid. The used case is indeed called kebab-case. |
I think it's best to add links to definitions of camel/kebab case. |
The names are not the real component names. It's just to illustrate that when defining the component, you do it like this: myCustomComponent. And when using it in the template do: my-custom-component |
cb31067 hopefully improves the explanation of casing. |
Thanks for accepting the suggestion 👍 :) |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information:
In line no 71 and 72
camelCase
is directive name and in HTML the it is said that it should be kebab-case where as it should be 'camel-case'.I felt that beginners who is trying to learn from tutorial can get confused.