-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(ngRepeat): I added the phrase "and by age" on line 236 #15037
Conversation
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Technically, you can only filter by name OR by age, not by both. |
That is correct, I will make that change |
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field. PR (#15037)
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field. PR (angular#15037)
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field. PR (angular#15037)
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field. PR (angular#15037)
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field. PR (angular#15037)
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field. PR (angular#15037)
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field. PR (#15037)
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field. PR (#15037)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
No change in behavior introduced
What is the new behavior (if this is a feature change)?
No change in behavior introduced
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.