Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngRepeat): I added the phrase "and by age" on line 236 #15037

Merged
merged 2 commits into from
Aug 17, 2016

Conversation

dulybon1
Copy link
Contributor

@dulybon1 dulybon1 commented Aug 17, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

docs update

What is the current behavior? (You can also link to an open issue here)

No change in behavior introduced

What is the new behavior (if this is a feature change)?

No change in behavior introduced

Does this PR introduce a breaking change?

No

Please check if the PR fulfills these requirements

Other information:

The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dulybon1
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Narretz
Copy link
Contributor

Narretz commented Aug 17, 2016

Technically, you can only filter by name OR by age, not by both.

@dulybon1
Copy link
Contributor Author

That is correct, I will make that change

@Narretz Narretz merged commit c54f7a9 into angular:master Aug 17, 2016
Narretz pushed a commit that referenced this pull request Aug 17, 2016
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

PR (#15037)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

PR (angular#15037)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

PR (angular#15037)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

PR (angular#15037)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

PR (angular#15037)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

PR (angular#15037)
petebacondarwin pushed a commit that referenced this pull request Nov 23, 2016
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

PR (#15037)
petebacondarwin pushed a commit that referenced this pull request Nov 24, 2016
The example seems to also be filtering by age. It threw me off a bit because I was getting results when I entered numbers in the input field.

PR (#15037)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants