This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(*): switch from JSHint/JSCS to ESLint #14993
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mgol
force-pushed
the
eslint-1.5
branch
2 times, most recently
from
bbead8c to
58829ce
Compare
Partially cherry-picked from c322032 Ref angular#14952
|
Only 308 files to review :-/ |
|
I have LGTM the following files:
|
| @@ -25,13 +26,13 @@ searchDataRequest.onload = function() { | |||
| searchData.forEach(function(page) { | |||
| index.add(page); | |||
| }); | |||
| postMessage({ e: 'index-ready' }); | |||
| postMessage({e: 'index-ready'}); | |||
There was a problem hiding this comment.
Ooc, couldn't this also be self.postMessage? Is there any reason why you usd it below but not here (just being curious)?
There was a problem hiding this comment.
Good point; I'll fix that after this PR lands on master and then backport it.
|
A couple of minor remarks/questions, but nothing blocking. |
|
parse.js, sanitize.js, compile.js, jqlite.js and sce.js LGTM |
|
Merged as b1bc251. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
A build-related refactor.
What is the current behavior? (You can also link to an open issue here)
Code is linted via JSHint+JSCS.
What is the new behavior (if this is a feature change)?
Code is linted via ESLint.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information:
This is the last commit of PR #14952 backported to the
v1.5.xbranch with some required changes and.catch -> ['catch'],.finally -> ['finally']. The other commits from that PR are already backported; they weren't dangerous and cherry-picked cleanly.This needs to be reviewed with two things in mind: the PR shouldn't introduce security issues and backwards incompatible changes.