This repository was archived by the owner on Apr 12, 2024. It is now read-only.
doc(guide/Animations): Integrates the styles #14960
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the css file used here containing 2 the same "sample-show-hide" classes so would like to move them together Also, inline styles are used in 2 elements so integrated them with this as well. This increases the height of doc a little bit. No related issues :).
|
I tweaked it a bit and merged. Thx! |
gkalpak
pushed a commit
that referenced
this pull request
Jul 28, 2016
Remove unnecessary inline styles, merge styles for identical selectors and clean up. Closes #14960
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update
What is the current behavior? (You can also link to an open issue here)
Works fine as usual, just would like to provide more solid code.
What is the new behavior (if this is a feature change)?
Would be the same.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
Currently the css file used here containing 2 the same "sample-show-hide"
classes so would like to move them together Also, inline styles are used in 2
elements so integrated them with this as well. This increases the height of
doc a little bit.
No related issues :).